next/sv/508/20240628/v1 #1947
Merged
next/sv/508/20240628/v1 #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inashivb
approved these changes
Jul 2, 2024
| @@ -0,0 +1 @@ | |||
| rate_filter gen_id 1, sig_id 1000001, track by_flow, count 3, seconds 60, new_action alert, timeout 1000 | |||
There was a problem hiding this comment.
Again confused a bit, why should a drop rule be allowed to change action?
Related to #1893 (review), perhaps for later discussion, what a terminating action for packet should be.
There was a problem hiding this comment.
I don't know of a good use case for it, but I think the rate_filter does support it. It's coming from the Snort language, so not sure if this case was considered at the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging: